Skip to content

Stabilize hex_literal_case#6935

Open
tapanprakasht wants to merge 3 commits into
rust-lang:mainfrom
tapanprakasht:stabilize_hex_literal_case
Open

Stabilize hex_literal_case#6935
tapanprakasht wants to merge 3 commits into
rust-lang:mainfrom
tapanprakasht:stabilize_hex_literal_case

Conversation

@tapanprakasht
Copy link
Copy Markdown

Stabilizing hex_literal_case
This PR try to address the issue #5081

@rustbot rustbot added the S-waiting-on-review Status: awaiting review from the assignee but also interested parties. label May 31, 2026
Comment thread tests/source/configs/hex_literal_case/hex_literal_lower.rs
Copy link
Copy Markdown
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying to get this option stabilized. I think hex_literal_case is a good candidate for stabilization. I don't see any bugs in the backlog, and I assume that it's being used by projects out in the wild, but we should try to confirm if there's a good amount of real world usage.

Also, For consistency with other config options, Let's move all of these tests to tests/{source|target}/configs/hex_literal_case

@rustbot author

View changes since this review

@rustbot rustbot removed the S-waiting-on-review Status: awaiting review from the assignee but also interested parties. label Jun 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 1, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: awaiting some action (such as code changes or more information) from the author. label Jun 1, 2026
@tapanprakasht tapanprakasht force-pushed the stabilize_hex_literal_case branch from 1df9e86 to 7bbfcf2 Compare June 2, 2026 16:29
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 2, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tapanprakasht
Copy link
Copy Markdown
Author

Thanks for trying to get this option stabilized. I think hex_literal_case is a good candidate for stabilization. I don't see any bugs in the backlog, and I assume that it's being used by projects out in the wild, but we should try to confirm if there's a good amount of real world usage.

Also, For consistency with other config options, Let's move all of these tests to tests/{source|target}/configs/hex_literal_case

@rustbot author

View changes since this review

Thanks for reviewing the changes. I have added more test cases as suggested and also moved the test cases under config folder.

Regarding the real world use case, Rust for Linux project expecting to stablize hex_literal_case formatter. Here is the associated ticket containing the list. Rust-for-Linux/linux#398

@tapanprakasht
Copy link
Copy Markdown
Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants